Skip to content

Avoid using env::temp when linking a binary #150311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ChrisDenton wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Avoid using env::temp when linking a binary #150311

ChrisDenton wants to merge 2 commits into from
+13 −14

Conversation

@ChrisDenton
Copy link
Member

@ChrisDenton ChrisDenton commented Dec 23, 2025 •
edited by rustbot
Loading

This keeps all build artefacts (even temporary ones) within the build directory.

Fixes #139963

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2025

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ChrisDenton
ChrisDenton commented Dec 23, 2025
View reviewed changes
Kivooeo
Kivooeo approved these changes Dec 23, 2025
View reviewed changes
Copy link
Member

@Kivooeo Kivooeo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable change to me

View changes since this review

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Dec 23, 2025
@ChrisDenton ChrisDenton force-pushed the no-temp branch 2 times, most recently from 09a60f4 to 7a6edc0 Compare December 23, 2025 17:19
@ChrisDenton
Avoid using env::temp when linking a binary
306bd5e 
This keeps all build artefacts (even temporary ones) within the build directory.
@ChrisDenton
Copy link
Member Author

ChrisDenton commented Dec 23, 2025

Fixed the invalid-tmpdir-env-var test to check it doesn't ICE rather than looking for a particular message. Because rustc might no longer use the tempdir. If preserving the error message is important then I could find somewhere in the compiler to insert a check though I'm not sure that it's worth it.

@Kivooeo
Copy link
Member

Kivooeo commented Dec 23, 2025

I don't think it's worth adding this check

r? me

@rustbot rustbot assigned Kivooeo and unassigned jackh726 Dec 23, 2025
Kivooeo
Kivooeo reviewed Dec 23, 2025
View reviewed changes
Copy link
Member

@Kivooeo Kivooeo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

View changes since this review

@ChrisDenton
Rename invalid-tmpdir-env-var
d694347 
to invalid-tmpdir-no-ice
@Kivooeo
Copy link
Member

Kivooeo commented Dec 23, 2025

r=me once CI is green

@ChrisDenton
Copy link
Member Author

ChrisDenton commented Dec 23, 2025

@bors r=Kivooeo

@bors
Copy link
Collaborator

bors commented Dec 23, 2025

📌 Commit d694347 has been approved by Kivooeo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 23, 2025
@matthiaskrgr
Rollup merge of rust-lang#150311 - ChrisDenton:no-temp, r=Kivooeo
283f11d 
Avoid using env::temp when linking a binary

This keeps all build artefacts (even temporary ones) within the build directory.

Fixes rust-lang#139963
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 23, 2025
Closed
bors added a commit that referenced this pull request Dec 23, 2025
@bors
Auto merge of #150317 - matthiaskrgr:rollup-6uty16z, r=matthiaskrgr
7a53ec4 
Rollup of 5 pull requests

Successful merges:

 - #150182 (Don't export upstream monomorphizations from compiler-builtins)
 - #150216 (Tidying up tests/ui/issues 15 tests [6/N])
 - #150308 (Update bors configuration)
 - #150311 (Avoid using env::temp when linking a binary)
 - #150314 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Dec 23, 2025

@bors r-
#150317 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kivooeo Kivooeo Kivooeo approved these changes

Assignees

@Kivooeo Kivooeo

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rustc_codegen_ssa should write temporary files to the output directory

7 participants

@ChrisDenton @rustbot @rust-log-analyzer @Kivooeo @bors @matthiaskrgr @jackh726